feat: add support for embedded cluster updates #4201
Merged
+482
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-93834/productize-autopilot-upgrades
branch
5 times, most recently
from
d7c0bb4 to
76f1c5a
Compare
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-93834/productize-autopilot-upgrades
branch
3 times, most recently
from
9ec8de6 to
2a48633
Compare
we now support embedded cluster upgrades together with the kots app upgrade. users can provide their own embedded cluster config object that is then applied to the cluster when it differs from the current active one.
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-93834/productize-autopilot-upgrades
branch
from
2a48633 to
319508e
Compare
cbodonnell
reviewed
Dec 7, 2023
cbodonnell
reviewed
Dec 7, 2023
cbodonnell
reviewed
Dec 7, 2023
cbodonnell
reviewed
Dec 7, 2023
| if err != nil { | ||
| return false, err | ||
| } | ||
| return !bytes.Equal(serializedCur, serializedNew), nil |
There was a problem hiding this comment.
would this allow a downgrade of the k8s cluster since it's just an equality comparison?
There was a problem hiding this comment.
it would allow applying a spec that requested that, but k0s will refuse
cbodonnell
reviewed
Dec 7, 2023
cbodonnell
reviewed
Dec 7, 2023
sgalsaleh
reviewed
Dec 7, 2023
sgalsaleh
reviewed
Dec 7, 2023
sgalsaleh
reviewed
Dec 7, 2023
sgalsaleh
reviewed
Dec 7, 2023
laverya
reviewed
Dec 7, 2023
laverya
reviewed
Dec 7, 2023
laverya
reviewed
Dec 7, 2023
cbodonnell
reviewed
Dec 7, 2023
cbodonnell
reviewed
Dec 7, 2023
cbodonnell
previously approved these changes
Dec 7, 2023
laverya
approved these changes
Dec 7, 2023
ricardomaraschini
deleted the
ricardomaraschini/sc-93834/productize-autopilot-upgrades
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We now support Embedded Cluster upgrades as part of a with the KOTS application upgrade. Users are able to provide their own Embedded Cluster Config object that is then applied to the cluster when it differs from the current active configuration.
Special notes for your reviewer:
Most of the work here has been leveraged in collaboration with Craig, I believe he has enough context on everything here. All that has been implemented here is supposed to be a no-op when running on top of another type of cluster (for instance, kURL). If you can pay special attention to this detail during the review that would be great.
Does this PR introduce a user-facing change?
Does this PR require documentation?
Most likely we need to document the new "Cluster State" that is presented on the main screen: